Avoid calling deprecated ODBC functions #17556
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering when That said, individual drivers might not support all the functionality, but if we're building against a driver manager as we should, it should handle that for us. |
|
Yeah, I think pursuing #15630/#15727 is overdue. And I've noticed that the ODBC cursor library is deprecated ( |
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead.
cmb69
force-pushed
the
cmb/odbc-deprecated
branch
from
743bec7 to
072062e
Compare
NattyNarwhal
pushed a commit
to NattyNarwhal/php-src
that referenced
this pull request
Aug 11, 2025
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead. (This is based on phpGH-17556, but just assumes ODBC 3.x.)
NattyNarwhal
pushed a commit
to NattyNarwhal/php-src
that referenced
this pull request
Aug 12, 2025
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead. (This is based on phpGH-17556, but just assumes ODBC 3.x.)
NattyNarwhal
pushed a commit
to NattyNarwhal/php-src
that referenced
this pull request
Aug 12, 2025
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead. (This is based on phpGH-17556, but just assumes ODBC 3.x.)
NattyNarwhal
added a commit
that referenced
this pull request
Aug 12, 2025
* Remove references to ODBCVER and assume ODBC 3.x See https://wiki.php.net/rfc/deprecations_php_8_5#remove_support_for_older_odbc_versions * Avoid calling deprecated ODBC functions `SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`, `SQLGetConnectAttr`, and `SQLSetStmtAttr` instead. (This is based on GH-17556, but just assumes ODBC 3.x.) * Remove wrappers for SQLColAttribute We don't need to support the old way of doing it. * Just call SQLAllocHandle directly Again, no need for the version specific wrapper * Update NEWS for ODBCVER in beta2 * [skip ci] UPGRADING for ODBCVER changes --------- Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLGetConnectOption,SQLSetConnectOptionandSQLSetStmtOptionare deprecated, so if ODBC 3 is available, we useSQLSetConnectAttr,SQLGetConnectAttr, andSQLSetStmtAttrinstead.I'm not quite sure how to actually handle this best. Assuming that we won't require ODBC >= 3, some of the error messages would need to be adapted (e.g. we should not report an issue with
SQLConnectOption, when we actually calledSQLSetConnectAttr. Furthermore, the generic replacement inodbc_setoption()might be too presumptious (from looking at sqlext.h, it seems to be okay, but who knows). Possibly, we should deprecate this PHP function altogether (at least the docs could need some update).¯\(ツ)/¯
A possible alternative to the PR as is would be to introduce general shims as macros, but this might cause even more confusion.
Anyhow, we should have a look at the double casts
(SQLPOINTER) (intptr_t)(without, Clang 18.1.8 complains); we should probably use integer types which have the same size as a pointer in the first place.